Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v8/react): Add a handled prop to ErrorBoundary #14978

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat(v8/react): Add a handled prop to ErrorBoundary #14978

merged 2 commits into from
Jan 10, 2025
+51 −42

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 10, 2025 •
edited
Loading

backport of #14560

@HHK1 @Lms24
feat(react): Add a handled prop to ErrorBoundary (#14560)
e5715c3 
The previous behaviour was to rely on the presence of the `fallback`
prop to decide if the error was considered handled or not. The new
property lets users explicitly choose what should the handled
status be. If omitted, the old behaviour is still applied.
@Lms24 Lms24 requested review from a team as code owners January 10, 2025 12:22
@Lms24 Lms24 changed the base branch from develop to v8 January 10, 2025 12:23
@Lms24 Lms24 requested review from lforst and AbhiPrasad and removed request for a team January 10, 2025 12:23
@Lms24 Lms24 mentioned this pull request Jan 10, 2025
Closed
@Lms24 Lms24 enabled auto-merge (squash) January 10, 2025 12:27
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.85 KB - -
@sentry/browser (incl. Tracing, Replay) 73.09 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.48 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.4 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.34 KB - -
@sentry/browser (incl. Feedback) 39.5 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.69 KB - -
@sentry/react 25.97 KB +0.06% +14 B 🔺
@sentry/react (incl. Tracing) 38.67 KB +0.04% +13 B 🔺
@sentry/vue 27.57 KB - -
@sentry/vue (incl. Tracing) 37.71 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.49 KB - -
CDN Bundle (incl. Tracing) 37.56 KB - -
CDN Bundle (incl. Tracing, Replay) 72.75 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 78.11 KB - -
CDN Bundle - uncompressed 71.93 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.42 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.5 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.6 KB - -
@sentry/nextjs (client) 38.92 KB - -
@sentry/sveltekit (client) 36.36 KB - -
@sentry/node 162.8 KB - -
@sentry/node - without tracing 98.94 KB - -
@sentry/aws-serverless 126.63 KB - -

View base workflow run

@Lms24 Lms24 merged commit fda1aee into v8 Jan 10, 2025
77 checks passed
@Lms24 Lms24 deleted the lms/feat-react-handled-prop-v8 branch January 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @lforst @HHK1