Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Ensure NODE_OPTIONS is not passed to worker threads #14824

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 22, 2024

Just like execArgv can cause --import and --require to be preloaded in worker threads and cause infinite loops, NODE_OPTIONS can cause this too.

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.16 KB - -
@sentry/browser - with treeshaking flags 21.83 KB - -
@sentry/browser (incl. Tracing) 35.66 KB - -
@sentry/browser (incl. Tracing, Replay) 72.91 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.31 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.32 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.71 KB - -
@sentry/browser (incl. Feedback) 39.91 KB - -
@sentry/browser (incl. sendFeedback) 27.77 KB - -
@sentry/browser (incl. FeedbackAsync) 32.53 KB - -
@sentry/react 25.88 KB - -
@sentry/react (incl. Tracing) 38.51 KB - -
@sentry/vue 27.38 KB - -
@sentry/vue (incl. Tracing) 37.51 KB - -
@sentry/svelte 23.31 KB - -
CDN Bundle 24.26 KB - -
CDN Bundle (incl. Tracing) 35.81 KB - -
CDN Bundle (incl. Tracing, Replay) 70.92 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.21 KB - -
CDN Bundle - uncompressed 71.32 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.78 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.85 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.05 KB - -
@sentry/nextjs (client) 38.79 KB - -
@sentry/sveltekit (client) 36.18 KB - -
@sentry/node 158 KB +0.01% +15 B 🔺
@sentry/node - without tracing 98.89 KB +0.02% +16 B 🔺
@sentry/aws-serverless 126.62 KB +0.02% +17 B 🔺

View base workflow run

@Lms24 Lms24 merged commit 9b1ab0e into develop Dec 23, 2024
110 checks passed
@Lms24 Lms24 deleted the timfish/fix/ensure-no-node-options-worker branch December 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants