-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): Bump astro from 4.13.3 to 4.16.17 in /dev-packages/e2e-tests/test-applications/astro-4 #14781
Closed
dependabot
wants to merge
1
commit into
develop
from
dependabot/npm_and_yarn/dev-packages/e2e-tests/test-applications/astro-4/astro-4.16.17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [astro](https://github.com/withastro/astro/tree/HEAD/packages/astro) from 4.13.3 to 4.16.17. - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/[email protected]/packages/astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/[email protected]/packages/astro) --- updated-dependencies: - dependency-name: astro dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
labels
Dec 18, 2024
AbhiPrasad
previously approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dependabot squash and merge
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Seems like we have an actual e2e test failure |
Superseded by #14807. |
dependabot
bot
deleted the
dependabot/npm_and_yarn/dev-packages/e2e-tests/test-applications/astro-4/astro-4.16.17
branch
December 19, 2024 15:44
Lms24
added a commit
that referenced
this pull request
Dec 20, 2024
In our Astro-4 E2E test app, Astro's Node adapter was pinned to a bad version that didn'T work correctly with newer Astro versions. We pinned the Astro version a while ago in #14030 to unblock CI but looks like we just didn't follow up with investigating what caused the issue back then. This came up again when dependabot tried to bump the Astro version in #14781 and #14807 and as a result #14808 was opened. This PR now - bumps the Node adapter version which makes newer Astro version function properly again - updates `astro` to the latest v4 version (which is why I closed #14807) closes #14808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps astro from 4.13.3 to 4.16.17.
Release notes
Sourced from astro's releases.
... (truncated)
Changelog
Sourced from astro's changelog.
... (truncated)
Commits
ba4aac1
[ci] release (#12648)e7d14c3
fix:checkOrigin
headers check (#12632)6eac6ba
[ci] release (#12536)65e50eb
Fix JPEG image size determination (#12542)6fc29e3
fix(deps): update all non-major dependencies (#12410)cf0d8b0
fix(i18n): render404.astro
when i18n is enabled (#12525)36d8d92
[ci] release (#12501)b140a3f
fix(routing): don't access Request headers (#12498)b9c05f4
[ci] release (#12452)e329657
[ci] formatDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @AbhiPrasad.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.