feat!: Bump typescript to ~5.0.0
#14758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/bump-typescript
branch
from
b894c53 to
0b9bfdc
Compare
mydea
commented
Dec 17, 2024
| @@ -444,7 +444,8 @@ describe('markFunctionWrapped', () => { | |||
| const wrappedFunc = jest.fn(); | |||
| markFunctionWrapped(wrappedFunc, originalFunc); | |||
|
|
|||
| expect((wrappedFunc as WrappedFunction).__sentry_original__).toBe(originalFunc); | |||
| // cannot wrap because it is frozen, but we do not error! | |||
There was a problem hiding this comment.
huh, why did this test pass before? 😅 some ts bug or so? The new behavior is def. the actual expected behavior!
mydea
force-pushed
the
fn/bump-typescript
branch
from
0b9bfdc to
042c25d
Compare
mydea
commented
Dec 17, 2024
| CpuProfilerBindings.startProfiling(name); | ||
| await fn(); | ||
| return CpuProfilerBindings.stopProfiling(name, format); | ||
| return CpuProfilerBindings.stopProfiling(name, ProfileFormat.THREAD); |
There was a problem hiding this comment.
This started complaining in TS, no idea why. I fixed it by just inlining the one place that we used a different format.
mydea
force-pushed
the
fn/bump-typescript
branch
2 times, most recently
from
ad2f77c to
080fc65
Compare
mydea
commented
Dec 18, 2024
| @@ -53,6 +53,8 @@ In preparation for the OpenTelemetry SDK v2, which will raise the minimum requir | |||
|
|
|||
| Additionally, like the OpenTelemetry SDK, the Sentry JavaScript SDK will follow [DefinitelyType's version support policy](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) which has a support time frame of 2 years for any released version of TypeScript. | |||
|
|
|||
| Older Typescript versions _may_ still work, but we will not test them anymore and no more guarantees apply. | |||
There was a problem hiding this comment.
Added this note, not 100% sure if this makes sense? 🤔
There was a problem hiding this comment.
yeah that feels reasonable to me.
There was a problem hiding this comment.
No hard opinions but personally if a sentence effectively says nothing, which is the case for this one I believe, I would not write it down.
mydea
commented
Dec 18, 2024
| @@ -158,7 +158,7 @@ export function getLocationHref(): string { | |||
| */ | |||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |||
| export function getDomElement<E = any>(selector: string): E | null { | |||
| if (WINDOW.document && WINDOW.document.querySelector) { | |||
| if (WINDOW.document && 'querySelector' in WINDOW.document) { | |||
There was a problem hiding this comment.
this complains about being deprecated, which is really stupid 😬 I wonder if we need this check at all anymore 🤔 but probably...
There was a problem hiding this comment.
https://caniuse.com/queryselector seems to be supported in all the environments we say we support, I think it's fine.
There was a problem hiding this comment.
I will remove/deprecate this in a separate PR!
timfish
approved these changes
Dec 18, 2024
AbhiPrasad
approved these changes
Dec 18, 2024
| @@ -53,6 +53,8 @@ In preparation for the OpenTelemetry SDK v2, which will raise the minimum requir | |||
|
|
|||
| Additionally, like the OpenTelemetry SDK, the Sentry JavaScript SDK will follow [DefinitelyType's version support policy](https://github.com/DefinitelyTyped/DefinitelyTyped#support-window) which has a support time frame of 2 years for any released version of TypeScript. | |||
|
|
|||
| Older Typescript versions _may_ still work, but we will not test them anymore and no more guarantees apply. | |||
There was a problem hiding this comment.
yeah that feels reasonable to me.
mydea
added a commit
that referenced
this pull request
Dec 19, 2024
I noticed this in #14758, this seems unnecessary and all browsers/envs we support should be able to handle this. We only use this in two places anyhow, so we can just guard there (a bit) for this instead. I will add a deprecation to v8 for this too, although this is just exported from core and will most likely not affect anybody.
mydea
force-pushed
the
fn/bump-typescript
branch
from
080fc65 to
f8d1138
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14757
For now we keep downleveling to 3.8, as long as that works without problems... we can still remove that in a follow up step.