fix(profiling): Don't put require, __filename and __dirname on global object
#14470
+109
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasBa
force-pushed
the
jb/profiling/local-require
branch
from
fc0e866 to
531e99b
Compare
JonasBa
force-pushed
the
jb/profiling/local-require
branch
from
531e99b to
7b07ab9
Compare
JonasBa
force-pushed
the
jb/profiling/local-require
branch
2 times, most recently
from
f2ef50c to
5f6dba9
Compare
JonasBa
force-pushed
the
jb/profiling/local-require
branch
from
5f6dba9 to
98e4eec
Compare
JonasBa
force-pushed
the
jb/profiling/local-require
branch
2 times, most recently
from
a45f224 to
32633bf
Compare
JonasBa
force-pushed
the
jb/profiling/local-require
branch
from
32633bf to
de1a11f
Compare
lforst
changed the title
lforst
changed the title
lforst
force-pushed
the
jb/profiling/local-require
branch
from
1eefeac to
5aa22a2
Compare
lforst
changed the title
require, __filename and __dirname on global object
lforst
force-pushed
the
jb/profiling/local-require
branch
from
5f9438b to
4d46401
Compare
lforst
force-pushed
the
jb/profiling/local-require
branch
from
4d46401 to
31653f3
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
I am gonna skip the test for now. I am not even sure what exactly we are testing here. |
lforst
approved these changes
Dec 16, 2024
|
@lforst I think it's fine to skip the test. The intention was to run a mjs script that uses profiling and check that globalThis.require was not available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes our CJS detection by no longer storing a reference to require on globalThis.
Fixes #14525, #13662