ref(nextjs): Make individual features opt into OTEL tracing #13910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
lforst-pages-router-api-route-otel
to
lforst-nextjs-otel
October 8, 2024 13:57
An error occurred while trying to automatically change base from
lforst-pages-router-api-route-otel
to
lforst-nextjs-otel
October 8, 2024 13:57
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
…nextjs-make-features-opt-into-otel-tracing
…ttp-integration' into lforst-nextjs-make-features-opt-into-otel-tracing
…nextjs-make-features-opt-into-otel-tracing
…t-into-otel-tracing
…nextjs-make-features-opt-into-otel-tracing
chargome
approved these changes
Oct 10, 2024
|
Merging because I can't be bothered to fix this one test failure in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically fully enables Next.js' OTEL tracing and allows features like API routes and data fetchers to opt out of nextjs otel tracing. Afterwards we can individually opt the features into Next.js otel tracing.