Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Move navigation span descriptions into op #13527

Merged
merged 9 commits into from
Sep 23, 2024
Merged
Prev Previous commit
Next Next commit
update request and response spans and update tests
0Calories committed Aug 29, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 7a10db719e2f38f33e0652d7a8df0cd00163f355
Original file line number Diff line number Diff line change
@@ -21,7 +21,8 @@ sentryTest('should add browser-related spans to pageload transaction', async ({
['loadEvent', 'request', 'response'].forEach(eventDesc =>
expect(browserSpans).toContainEqual(
expect.objectContaining({
description: eventDesc,
op: `browser.${eventDesc}`,
description: page.url(),
parent_span_id: eventData.contexts?.trace?.span_id,
}),
),
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ sentryTest('should add browser-related spans to pageload transaction', async ({

const requestSpan = browserSpans!.find(({ op }) => op === 'browser.request');
expect(requestSpan).toBeDefined();
expect(requestSpan?.description).toBe('test');
expect(requestSpan?.description).toBe(page.url());

const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
expect(measureSpan).toBeDefined();