try running directly

getsentry · Dec 2, 2024 · 083594e · 083594e
1 parent 79314fe
commit 083594e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1205,8 +1205,10 @@ jobs:
       - name: Run E2E test
         working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
         timeout-minutes: 10
-        run:
+        run: |
           xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:assert
+          npm pkg set type=module
+          node index.mjs
 
   job_required_jobs_passed:
     name: All required jobs passed or were skipped

diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs b/dev-packages/e2e-tests/test-applications/node-profiling/index.mjs
@@ -29,3 +29,5 @@ Sentry.startSpan({ name: 'Precompile test' }, async () => {
 });
 
 assertUnpatechedRequire();
+
+console.log('✅ Require is not patched');
diff --git a/dev-packages/e2e-tests/test-applications/node-profiling/package.json b/dev-packages/e2e-tests/test-applications/node-profiling/package.json
@@ -5,12 +5,12 @@
   "scripts": {
     "typecheck": "tsc --noEmit",
     "build": "node build.mjs && node build.shimmed.mjs",
-    "test": "node dist/index.js && node --experimental-require-module dist/index.js && node dist/index.shimmed.mjs && pnpm run test:mjs",
+    "test": "node dist/index.js && node --experimental-require-module dist/index.js && node dist/index.shimmed.mjs",
     "clean": "npx rimraf node_modules dist",
     "test:electron": "$(pnpm bin)/electron-rebuild && playwright test",
     "test:build": "pnpm run typecheck && pnpm run build",
     "test:assert": "pnpm run test && pnpm run test:electron",
-    "test:mjs": "node --version && npm pkg set type=module && node index.mjs"
+    "test:mjs": "node index.mjs"
   },
   "dependencies": {
     "@electron/rebuild": "^3.7.0",
Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,3 +29,5 @@ Sentry.startSpan({ name: 'Precompile test' }, async () => {
		});

		assertUnpatechedRequire();

		console.log('✅ Require is not patched');