Migrate spring boot dependencies to version catalog #4441
+282
−254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbro112
requested review from
adinauer,
romtsn,
stefanosiano,
markushi and
lcian
as code owners
rbro112
changed the title
runningcode
reviewed
May 23, 2025
buildSrc/src/main/java/Config.kt
Outdated
| val springBoot3StarterJdbc = "org.springframework.boot:spring-boot-starter-jdbc:$springBoot3Version" | ||
| val springBoot3StarterActuator = "org.springframework.boot:spring-boot-starter-actuator:$springBoot3Version" | ||
| val springBoot3StarterOpenTelemetry = "io.opentelemetry.instrumentation:opentelemetry-spring-boot-starter:${OpenTelemetry.otelInstrumentationVersion}" | ||
| // val springBootStarter = "org.springframework.boot:spring-boot-starter:$springBootVersion" |
There was a problem hiding this comment.
don’t forget to remove this before merging!
lcian
approved these changes
May 23, 2025
adinauer
reviewed
May 23, 2025
gradle/libs.versions.toml
Outdated
| spring-boot-two = { id = "org.springframework.boot", version.ref = "springTwo" } | ||
| spring-boot-three = { id = "org.springframework.boot", version.ref = "springThree" } | ||
| springboot2 = { id = "org.springframework.boot", version.ref = "springboot2" } | ||
| springboot3 = { id = "org.springframework.boot", version.ref = "springboot2" } |
There was a problem hiding this comment.
Should this be?
Suggested change
| springboot3 = { id = "org.springframework.boot", version.ref = "springboot2" } | |
| springboot3 = { id = "org.springframework.boot", version.ref = "springboot3" } |
rbro112
force-pushed
the
ryan/version-catalog-10
branch
2 times, most recently
from
63fff7d to
a25a54e
Compare
* Bump Spring Boot to 3.4.1 * changelog * update to spring boot 3.4.2 * fix jdbc dependencies for jakarta samples * update readme * update logback dependency in jakarta samples * [WIP] test with spring boot 3.5.0 * Update buildSrc/src/main/java/Config.kt * adapt to breaking change in spring-graphql-1.4.0, fix test, add withOptions to sample * bump to Spring Boot 3.5.0 * trigger CI? * update spring boot version in toml * move changelog * revert maven milestone repos * fix changelog * restore old changelog entry * fix gh pr link --------- Co-authored-by: Alexander Dinauer <[email protected]> Co-authored-by: Alexander Dinauer <[email protected]> Co-authored-by: Lorenzo Cian <[email protected]>
…ead of `OtelSentryPropagator` (#4434) * Fork isolation scope in SpanProcessor * improve creator strings * changelog * remove irrelevant tests
rbro112
force-pushed
the
ryan/version-catalog-10
branch
from
a25a54e to
77f5f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Version catalog adoption
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps