Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v22 of graphql-java via sentry-graphql-22 #3740

Open
wants to merge 2 commits into
base: feat/spring-request-body-form
Choose a base branch
from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 2, 2024

📜 Description

  • Introduce sentry-graphql-22 to support v22 of graphql-java
    • Please note the different package for SentryInstrumenter for v22: io.sentry.graphql22.SentryInstrumentation
  • Both sentry-graphql and sentry-graphql-22 use sentry-graphql-core
  • BeforeSpanCallback on SentryInstrumenter has been deprecated, the one from SentryGraphqlInstrumentation should be used instead

💡 Motivation and Context

Pt. 1 of fixing #3737

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

  • Auto install should install sentry-graphql-22 instead of sentry-graphql depending on version of graphql-java
  • docs

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add support for v22 of `graphql-java` via `sentry-graphql-22` ([#3740](https://github.com/getsentry/sentry-java/pull/3740))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3cc76b4

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 400.04 ms 490.84 ms 90.80 ms
Size 1.70 MiB 2.35 MiB 669.06 KiB

Baseline results on branch: feat/spring-request-body-form

Startup times

Revision Plain With Sentry Diff
24c454d 461.16 ms 540.57 ms 79.41 ms
8bc8101 404.12 ms 460.98 ms 56.86 ms

App size

Revision Plain With Sentry Diff
24c454d 1.70 MiB 2.35 MiB 669.06 KiB
8bc8101 1.70 MiB 2.35 MiB 669.06 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant