Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach request body for application/x-www-form-urlencoded requests in Spring #3731

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

Closes #3656

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 72aa792

Copy link
Contributor

github-actions bot commented Sep 30, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 404.12 ms 460.98 ms 56.86 ms
Size 1.70 MiB 2.35 MiB 669.06 KiB

Previous results on branch: feat/spring-request-body-form

Startup times

Revision Plain With Sentry Diff
24c454d 461.16 ms 540.57 ms 79.41 ms

App size

Revision Plain With Sentry Diff
24c454d 1.70 MiB 2.35 MiB 669.06 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM codewise.
We could extend the SentrySpringFilterTest.caches request depending on the maxRequestBodySize value and request body length to include the new mimetype

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM 👍

@adinauer adinauer merged commit 4e23b92 into 8.x.x Oct 4, 2024
21 of 22 checks passed
@adinauer adinauer deleted the feat/spring-request-body-form branch October 4, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants