-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiate continuous profiling v8 (p3) #3725
Open
stefanosiano
wants to merge
6
commits into
feat/continuous-profiling-part2
Choose a base branch
from
feat/continuous-profiling-part3
base: feat/continuous-profiling-part2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Instantiate continuous profiling v8 (p3) #3725
stefanosiano
wants to merge
6
commits into
feat/continuous-profiling-part2
from
feat/continuous-profiling-part3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless added continuous profiler to SentryOptions
…ontinuous-profiling-part3 # Conflicts: # sentry/src/main/java/io/sentry/SentryTracer.java # sentry/src/test/java/io/sentry/OutboxSenderTest.kt
…iler updated DefaultTransactionPerformanceCollector to work with string ids other than transactions fixed ProfileChunk measurements being modifiable from other code added thread id and name to SpanContext.data
7 tasks
stefanosiano
changed the title
Instantiate continuous profiling (p3)
Instantiate continuous profiling v8 (p3)
Sep 26, 2024
stefanosiano
changed the base branch from
main
to
feat/continuous-profiling-part2
September 26, 2024 11:00
|
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
September 26, 2024 11:15
Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added profile context to SentryTracer
removed isProfilingEnabled from AndroidContinuousProfiler, as it's useless
added continuous profiler to SentryOptions
added DefaultTransactionPerformanceCollector to AndroidContinuousProfiler and updated it to work with string ids other than transactions
fixed ProfileChunk measurements being modifiable from other code
added thread id and name to SpanContext.data
#skip-changelog
💡 Motivation and Context
Instantiate Continuous Profiler
Part 3 of #3710
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps