Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change payload for Continuous Profiling v8 (p2) #3711

Open
wants to merge 2 commits into
base: feat/continuous-profiling-part1
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

📜 Description

added profile_chunk envelope create
added IHub.captureProfileChunk and ISentryClient.captureProfileChunk
added profilerId and chunkId reset logic to AndroidContinuousProfiler
added absolute timestamps to ProfileMeasurementValue
added ProfileContext to Contexts

#skip-changelog

💡 Motivation and Context

Implements payload changes for Continuous Profiling
Part 2 of #3683

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added IHub.captureProfileChunk and ISentryClient.captureProfileChunk
added profilerId and chunkId reset logic to AndroidContinuousProfiler
added absolute timestamps to ProfileMeasurementValue
added ProfileContext to Contexts
Copy link
Contributor

github-actions bot commented Sep 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against ea0eb6e

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 453.58 ms 460.10 ms 6.52 ms
Size 1.70 MiB 2.35 MiB 669.02 KiB

Baseline results on branch: feat/continuous-profiling-part1

Startup times

Revision Plain With Sentry Diff
aa4590a 423.00 ms 498.52 ms 75.52 ms
229015a 396.02 ms 486.55 ms 90.53 ms

App size

Revision Plain With Sentry Diff
aa4590a 1.70 MiB 2.35 MiB 666.97 KiB
229015a 1.70 MiB 2.35 MiB 667.29 KiB

Previous results on branch: feat/continuous-profiling-part2

Startup times

Revision Plain With Sentry Diff
b509687 457.38 ms 494.96 ms 37.58 ms

App size

Revision Plain With Sentry Diff
b509687 1.70 MiB 2.35 MiB 668.62 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant