-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting sentry-native handler_strategy #3671
base: main
Are you sure you want to change the base?
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e6cd7c4 | 436.04 ms | 463.48 ms | 27.44 ms |
8cd4eed | 653.88 ms | 782.00 ms | 128.12 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e6cd7c4 | 1.70 MiB | 2.35 MiB | 661.99 KiB |
8cd4eed | 1.70 MiB | 2.35 MiB | 661.99 KiB |
…om:getsentry/sentry-java into feat/sentry-dotnet-inproc-handler-strategy
|
||
### Features | ||
|
||
- Add support for setting sentry-native handler_strategy ([#3671](https://github.com/getsentry/sentry-java/pull/3671)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 🚫 The changelog entry seems to be part of an already released section
## 7.15.0
.
Consider moving the entry to the## Unreleased
section, please.
@bitsandfoxes do you know if the underlying .NET issue is solved by this? Or in other words: Should we move forward with this and get it merged? |
AFAIK this will resolve dotnet/android#9055 |
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
@bitsandfoxes we eventually still want to have this merged, right? |
📜 Description
Bump sentry-native, add options to SentryAndroidOptions, extend sentry-native init code.
💡 Motivation and Context
getsentry/sentry-native#1026
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps