Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Delete intermediary artifact to encourage correct package #50

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

limbonaut
Copy link
Collaborator

Remove sentry-godot-gdextension artifact as the last step in CI, because it lacks executable permissions on crashpad_handler. These permissions are corrected in the "package" job which produces a separate artifact, so this encourages downloading the correct zip archive.

For more details, see #41
Resolves #41

@limbonaut limbonaut added bug Something isn't working github-actions labels Dec 21, 2024
@limbonaut limbonaut marked this pull request as ready for review December 21, 2024 14:38
@limbonaut limbonaut changed the title CI: Delete sentry-godot-gdextension artifact to encourage using the correct package ci: Delete sentry-godot-gdextension artifact to encourage correct package Dec 22, 2024
@limbonaut limbonaut changed the title ci: Delete sentry-godot-gdextension artifact to encourage correct package ci: Delete intermediary artifact to encourage correct package Dec 22, 2024
This is needed to encourage using the corrected artifact, and because
`sentry-godot-gdextension` artifact lacks executable permissions,
see #41
@bruno-garcia bruno-garcia merged commit ab1890f into main Dec 27, 2024
14 checks passed
@bruno-garcia bruno-garcia deleted the gha-cleanup-stage branch December 27, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix crashpad_handler missing executable bit in artifacts from the GHA workflow
2 participants