Fix crash on shutdown on Windows #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
force-pushed
the
fix/shutdown-crash-on-windows
branch
from
02e8727 to
8739e08
Compare
bitsandfoxes
approved these changes
Dec 4, 2024
| if (p_level == MODULE_INITIALIZATION_LEVEL_CORE) { | ||
| memdelete(SentrySDK::get_singleton()); | ||
| delete SentryOptions::get_singleton(); | ||
| if (p_level == MODULE_INITIALIZATION_LEVEL_SCENE) { |
There was a problem hiding this comment.
Is this the latest step? Could we uninstall even later?
There was a problem hiding this comment.
I'll see if I can push it to earlier/later stages. It's been problematic with LEVEL_CORE so far.
There was a problem hiding this comment.
Tracking in #39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash on Windows related to memory release, adds sanity checks and debug prints.