Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work-in-progress extension #3
Work-in-progress extension #3
Changes from all commits
7e6e048
9a2fc4f
d21f179
48c308a
bd10e3a
9b0f451
83d41c5
6a6bf17
04c9db9
ba88ded
380abaa
0e6af69
a01741f
423c9f7
3c833c8
72b016f
64227f1
5358cf9
61fe00e
f926752
14197e8
4c70b00
5eccba1
4fc1bca
bb663aa
7ea1f26
7b4369c
5be6e83
30e420e
aa748a1
cfbce15
258684b
bb4ccd1
0b0cbc5
5741c09
16124c5
ce47af4
1008d9c
610ec7d
b175ab9
dda74c9
f532e9e
1db81ef
7f3eb6f
e772cea
e570712
c4d375e
70f1663
ec3b439
40cf43b
26ebd04
6166482
9a057bd
b1a7fde
d6f7a3c
449aaab
3ae6409
31143a4
6edfd92
1055b08
dfabb74
8dd9fc2
281297a
f97ac76
46875c9
18c3607
0616c8a
08db81d
a161c37
321018a
24cc1ad
e7354d1
b7f671f
c6ac925
5c0de96
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so you need two sets of libraries:
Editor
andRelease
. TheRelease
ones actually make it into the exported game. Makes sense.I wonder if there is something that we can do with that. This way we have a guaranteed way of knowing whether the SDK is in use in the editor or in production. I'm thinking of debug logging, verbosity levels, error capture. We probably should not mess with default options tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are preprocessor defines for build options, and you can add your own, of course. Useful for conditional code inclusion for different builds, platforms, etc.