Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashpad_handler missing executable bit in artifacts from the GHA workflow #41

Closed
limbonaut opened this issue Dec 9, 2024 · 1 comment · Fixed by #50
Closed

Fix crashpad_handler missing executable bit in artifacts from the GHA workflow #41

limbonaut opened this issue Dec 9, 2024 · 1 comment · Fixed by #50
Assignees
@limbonaut
Labels
bug Something isn't working

Comments

@limbonaut
Copy link
Collaborator

limbonaut commented Dec 9, 2024 •
edited
Loading

crashpad_handler is uploaded without executable bit for Linux and macOS builds. This issue is caused by an old problem with upload-artifact:
@limbonaut limbonaut added the bug Something isn't working label Dec 9, 2024
@limbonaut limbonaut mentioned this issue Dec 9, 2024
Merged
@limbonaut limbonaut moved this to Todo in GDX Dec 11, 2024
@limbonaut limbonaut moved this from Todo to In Progress in GDX Dec 20, 2024
@limbonaut
Copy link
Collaborator Author

We're fixing permissions in a CI post-process step. It is still an issue if someone grabs sentry-godot-gdextension artifact instead of {{github.sha}}-named package. Maybe, we should be removing sentry-godot-gdextension artifact as the last step in CI.

limbonaut added a commit that referenced this issue Dec 21, 2024
@limbonaut
GHA: Delete sentry-godot-gdextension artifact to encourage using the …
bf1718e 
…package instead

`sentry-godot-gdextension` artifact lacks executable permissions
see #41
@limbonaut limbonaut mentioned this issue Dec 21, 2024
Merged
limbonaut added a commit that referenced this issue Dec 22, 2024
@limbonaut
ci: Delete intermediary artifact to encourage correct package
b258068 
This is needed to encourage using the corrected artifact, and because
`sentry-godot-gdextension` artifact lacks executable permissions,
see #41
@limbonaut limbonaut self-assigned this Dec 22, 2024
bruno-garcia pushed a commit that referenced this issue Dec 27, 2024
@limbonaut
ci: Delete intermediary artifact to encourage correct package (#50)
ab1890f 
This is needed to encourage using the corrected artifact, and because
`sentry-godot-gdextension` artifact lacks executable permissions,
see #41
@github-project-automation github-project-automation bot moved this from In Progress to Done in GDX Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@limbonaut limbonaut

Labels
bug Something isn't working
Projects
GDX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Delete intermediary artifact to encourage correct package getsentry/sentry-godot
1 participant
@limbonaut