Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace origin #849

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add trace origin #849

merged 4 commits into from
Jul 3, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Jul 1, 2024

Resolves #668

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.11%. Comparing base (77f9517) to head (0cfd1ef).

Files Patch % Lines
tracing.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
+ Coverage   82.05%   82.11%   +0.06%     
==========================================
  Files          51       51              
  Lines        4507     4518      +11     
==========================================
+ Hits         3698     3710      +12     
+ Misses        661      660       -1     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric
Copy link
Member

cleptric commented Jul 1, 2024

LGTM, anything else you want to add here?

@ribice ribice marked this pull request as ready for review July 1, 2024 21:03
@ribice
Copy link
Collaborator Author

ribice commented Jul 1, 2024

LGTM, anything else you want to add here?

No, just haven't had the chance to test it e2e.

@ribice
Copy link
Collaborator Author

ribice commented Jul 3, 2024

CleanShot 2024-07-03 at 12 30 10

These are visible in spans. Ready for review/merge now.

tracing.go Outdated Show resolved Hide resolved
@cleptric cleptric merged commit dafeb07 into master Jul 3, 2024
21 checks passed
@cleptric cleptric deleted the add-trace-origin branch July 3, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send span origin
2 participants