-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): add basic metrics type support #789
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #789 +/- ##
==========================================
- Coverage 83.15% 81.74% -1.41%
==========================================
Files 49 50 +1
Lines 4190 4427 +237
==========================================
+ Hits 3484 3619 +135
- Misses 565 659 +94
- Partials 141 149 +8 ☔ View full report in Codecov by Sentry. |
this was necessary since slices generics utilities (sort, etc.) were added in go 1.21 but we're currently constrained at 1.18
since we're stuck at v1.18 we'll have to define it ourselves
plus use empty char for substitution in tag values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some usage examples to the PR description. Did you already send some metrics to Sentry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, this metrics implementation would be so easy if we did #643 first.
log when the request sent to relay fails with a response code in the range [400, 599]
log failed requests when relay sends back a response with a status code in the range [400, 599]
Any updates for this? |
this PR aims at adding metrics type definition and the related serialization logic.
This does not include high-level APIs that will be used by the users (with proper aggregation/bucketing).
Example of how to send metrics through the
Transport
struct: