Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing without performance): set span on scope #750

Conversation

greywolve
Copy link
Contributor

This is part of a series of PRs for the "tracing without performance" feature.

For the case where performance is enabled we need to be able to get the tracing context from the active transaction and use that instead of the propagation context. So we need to way to access the span.

This PR adds support for setting a span on a scope. We can then access the span and get the current tracing context to pass through.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feat_tracing_without_performance@7182582). Click here to learn what that means.

Additional details and impacted files
@@                         Coverage Diff                         @@
##             feat_tracing_without_performance     #750   +/-   ##
===================================================================
  Coverage                                    ?   81.09%           
===================================================================
  Files                                       ?       49           
  Lines                                       ?     4777           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?     3874           
  Misses                                      ?      763           
  Partials                                    ?      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greywolve greywolve merged commit 55e776b into getsentry:feat_tracing_without_performance Nov 28, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants