feat(tracing without performance): add propagation context to scope #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat_tracing_without_performance #745 +/- ##
====================================================================
+ Coverage 80.77% 80.92% +0.15%
====================================================================
Files 47 49 +2
Lines 4701 4771 +70
====================================================================
+ Hits 3797 3861 +64
- Misses 765 768 +3
- Partials 139 142 +3 ☔ View full report in Codecov by Sentry. |
greywolve
commented
Nov 8, 2023
| DynamicSamplingContext DynamicSamplingContext `json:"-"` | ||
| } | ||
|
|
||
| func (p PropagationContext) MarshalJSON() ([]byte, error) { |
There was a problem hiding this comment.
Not sure if this is really needed, just added for completeness sake.
greywolve
force-pushed
the
tracing_without_performance_propagation_context
branch
from
7c381e7
to
5045587
Compare
cleptric
approved these changes
Nov 20, 2023
greywolve
force-pushed
the
tracing_without_performance_propagation_context
branch
from
f7ca999
to
77dfb21
Compare
greywolve
merged commit 7182582
into
getsentry:feat_tracing_without_performance
15 checks passed
greywolve
deleted the
tracing_without_performance_propagation_context
branch
greywolve
added a commit
that referenced
this pull request
Nov 30, 2023
…745) * feat(tracing without performance): add propagation context to scope * remove redundant dynamic context assignment * more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of a series of PRs for implementing tracing without performance.
This initial PR adds a
PropagationContextfield to the scope.