Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): start transaction for fasthttp integration #723

Merged
merged 10 commits into from
Mar 26, 2024

Conversation

aldy505
Copy link
Contributor

@aldy505 aldy505 commented Oct 1, 2023

I realized that only a few integration starts performance span for their HTTP handlers (such as net/http and Gin), the others are not. Here is my effort on fixing it for other integrations/frameworks.

This also introduces the GetTransactionFromContext function that takes the fasthttp.RequestCtx as input and returns *sentry.Span or nil. It handles that fasthttp.RequestCtx's context is not compatible with our sentry.GetHubFromContext due to different format of context key.

Discord link: https://discord.com/channels/621778831602221064/621786587939864586/1157114103156969513

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (5942155) to head (0623e4a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   81.84%   81.93%   +0.08%     
==========================================
  Files          48       48              
  Lines        4759     4782      +23     
==========================================
+ Hits         3895     3918      +23     
  Misses        725      725              
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric requested a review from ribice March 14, 2024 11:38
fasthttp/sentryfasthttp.go Show resolved Hide resolved
@aldy505 aldy505 requested a review from vaind March 26, 2024 13:11
@vaind vaind merged commit 71c244b into getsentry:master Mar 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants