Attach the X-Sentry-Auth header to /envelope requests
#709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleptric
commented
Sep 4, 2023
Comment on lines
+215
to
+216
| auth := fmt.Sprintf("Sentry sentry_version=%s, "+ | ||
| "sentry_client=%s/%s, sentry_key=%s", apiVersion, event.Sdk.Name, event.Sdk.Version, dsn.publicKey) |
There was a problem hiding this comment.
I removed sentry_timestamp, according to https://develop.sentry.dev/sdk/overview/#authentication
This key is effectively deprecated, and it is ignored on the receiving side. Use the sent_at envelope header instead.
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
cleptric
changed the title
X-Sentry-Auth header to /envelope requestsX-Sentry-Auth header to /envelope requests
tonyo
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After internal discussions, we're adding back the
X-Sentry-Authheader to requests to the/envelopeendpoint as it's more efficient than the envelope header auth.