Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OTel incorrect usage of attributes.Value.AsString resulting in an empty string for non-string values #684

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

vtfr
Copy link
Contributor

@vtfr vtfr commented Aug 1, 2023

Fixes #683

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.26% 🎉

Comparison is base (3a658da) 80.56% compared to head (f483a4e) 80.82%.

❗ Current head f483a4e differs from pull request most recent head e9f6ec0. Consider uploading reports for the commit e9f6ec0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   80.56%   80.82%   +0.26%     
==========================================
  Files          44       44              
  Lines        4460     4460              
==========================================
+ Hits         3593     3605      +12     
+ Misses        736      726      -10     
+ Partials      131      129       -2     
Files Changed Coverage Δ
otel/internal/utils/mapotelstatus.go 100.00% <100.00%> (+63.15%) ⬆️
otel/span_processor.go 94.33% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonyo tonyo merged commit cda691d into getsentry:master Aug 3, 2023
12 checks passed
@tonyo
Copy link
Contributor

tonyo commented Aug 3, 2023

Thanks @vtfr, this is great 👍

@vtfr vtfr deleted the fix/value-string-representation branch August 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTel] Non-string attributes are being sent as an empty string
3 participants