fix: Unsuccessful context enhancing should not drop frames

stacktrace.go

@@ -228,18 +228,16 @@ func contextifyFrames(frames []Frame) []Frame {
 	for _, frame := range frames {
 		lines, initial := sr.readContextLines(frame.AbsPath, frame.Lineno, contextLines)
 
-		if lines == nil {
-			continue
-		}
-
-		for i, line := range lines {
-			switch {
-			case i < initial:
-				frame.PreContext = append(frame.PreContext, string(line))
-			case i == initial:
-				frame.ContextLine = string(line)
-			default:
-				frame.PostContext = append(frame.PostContext, string(line))
+		if lines != nil {
+			for i, line := range lines {
+				switch {
+				case i < initial:
+					frame.PreContext = append(frame.PreContext, string(line))
+				case i == initial:
+					frame.ContextLine = string(line)
+				default:
+					frame.PostContext = append(frame.PostContext, string(line))
+				}
 			}
 		}
 

stacktrace_test.go

@@ -72,6 +72,26 @@ func TestStacktraceFrameContext(t *testing.T) {
 	})
 }
 
+func TestStacktraceUnsuccessfulContextifyShouldNotDropFrames(t *testing.T) {
+	frames := []Frame{{
+		Function:    "fnName",
+		Module:      "same",
+		Filename:    "wat.go",
+		AbsPath:     "this/doesnt/exist/wat.go",
+		Lineno:      1,
+		Colno:       2,
+	}, {
+		Function:    "fnNameFoo",
+		Module:      "sameFoo",
+		Filename:    "foo.go",
+		AbsPath:     "this/doesnt/exist/foo.go",
+		Lineno:      3,
+		Colno:       5,
+	}}
+	contextifiedFrames := contextifyFrames(frames)
+	assertEqual(t, len(contextifiedFrames), len(frames))
+}
+
 // https://github.com/pkg/errors
 func TestExtractStacktracePkgErrors(t *testing.T) {
 	err := RedPkgErrorsRanger()