Update CI #882
Open
Update CI #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LMK when this is ready for review |
@whatyouhide now 🙃 |
whatyouhide
requested changes
Apr 21, 2025
Comment on lines
+25
to
+26
| - elixir: "1.18" | ||
| otp: "27.2" |
There was a problem hiding this comment.
Was this change necessary?
| otp: '22.3.4' | ||
| os: ubuntu-20.04 | ||
| - elixir: "1.13" | ||
| otp: "25.3" |
There was a problem hiding this comment.
We need to leave a comment here saying that this is the lowest tested OTP version but technically we support back to OTP 22.
| - name: Download Mix dependencies | ||
| if: steps.mix-downloaded-deps-cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| if [ ${{ matrix.elixir }} != '1.13.4-otp-22' ]; then |
There was a problem hiding this comment.
All these checks against 1.13.4-otp-22 are broken now, as there's no such matrix.elixir value?
Comment on lines
+42
to
+43
| - name: Check out this repository | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
The indentation here is not a necessary change and makes the diff harder to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just bumps OSes and Elixir 1.13 to OTP 25.3. Previously used versions are no longer supported by GH and https://github.com/erlef/setup-beam