Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code coverage for Metrics #3094

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Improve code coverage for Metrics #3094

merged 7 commits into from
Jan 31, 2024

Conversation

jamescrosswell
Copy link
Collaborator

Resolves #3066

#skip-changelog

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (467676e) 76.53% compared to head (2ad2469) 76.95%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
+ Coverage   76.53%   76.95%   +0.41%     
==========================================
  Files         355      357       +2     
  Lines       13381    13463      +82     
  Branches     2656     2670      +14     
==========================================
+ Hits        10241    10360     +119     
+ Misses       2460     2422      -38     
- Partials      680      681       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescrosswell jamescrosswell marked this pull request as ready for review January 31, 2024 00:19
Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests! 🎉

@bitsandfoxes bitsandfoxes merged commit e0d87e4 into main Jan 31, 2024
21 checks passed
@bitsandfoxes bitsandfoxes deleted the metrics-tests branch January 31, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage for Metrics API
2 participants