-
-
Notifications
You must be signed in to change notification settings - Fork 219
Use Sentry CLI after build to upload symbols #2107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd to say, but that's some pretty msbuild code :)
Note, the verification snapshots previously had |
Another verification failure was due to the way we were scrubbing attributes on the API verification tests. On CI, the path string was sometimes long enough that the attribute was printed on two lines and we only scrubbed one of them. Fixed. |
Added the file hash verifications, and also went ahead and put the i686 (32-bit) versions in there too. Nuget size is 43MB, which is manageable. |
Going to do some refactoring before completing this, as we'll want to separate the Sentry CLI setup from the symbol upload part, such that we can re-use it for other Sentry CLI tasks like creating releases, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally seems good to go. Only a couple notes to clarify
As part of #2074, this PR adds the following:
Sentry
nuget packageCurrently requires setting the following environment variables manually before running the build.
SENTRY_AUTH_TOKEN
SENTRY_ORG
SENTRY_PROJECT
SENTRY_URL
(if self-hosted)See https://docs.sentry.io/product/cli/configuration/