-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(js): Update product pages to drop Set up
prefix in navigation
#13351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
|
Also make sure to use this in breadcrumbs instead of the actual page heading.
28d958f
to
be2b4f8
Compare
@mydea - I'm wondering about doing this for at least Python as well before merging this change. I should have some time next week to work on it if you don't get to it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This feature will be very useful. Code looks good to me, works on preview.
Done fully here instead: #13392 |
Also make sure to use this in breadcrumbs instead of the actual page heading.
Note that the pages themselves keep their "Set up XXX" heading, which makes sense IMHO.