Skip to content

feat(js): Update product pages to drop Set up prefix in navigation #13351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 11, 2025

Also make sure to use this in breadcrumbs instead of the actual page heading.

Note that the pages themselves keep their "Set up XXX" heading, which makes sense IMHO.

@mydea mydea requested review from sfanahata, codyde and chargome April 11, 2025 10:07
@mydea mydea self-assigned this Apr 11, 2025
Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 0:44am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 0:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 11, 2025 0:44am

Copy link

codecov bot commented Apr 11, 2025

Bundle Report

Changes will increase total bundle size by 14 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB 20 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/odG3G-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/odG3G-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/Q2bRB1ZYGnvmboilKq2N4/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/Q2bRB1ZYGnvmboilKq2N4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
2065.js 29 bytes 82.01kB 0.04%

Files in 2065.js:

  • ./src/components/breadcrumbs/index.tsx → Total Size: 1.16kB

mydea and others added 2 commits April 11, 2025 14:28
@sfanahata
Copy link
Contributor

@mydea - I'm wondering about doing this for at least Python as well before merging this change. I should have some time next week to work on it if you don't get to it first.

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this one.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This feature will be very useful. Code looks good to me, works on preview.

@mydea
Copy link
Member Author

mydea commented Apr 16, 2025

Done fully here instead: #13392

@mydea mydea closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants