-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(insights): move performance docs under insights #12720
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 320 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-edge-server-array-pushAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 the changes look fine to me, but it should really be up to a PM to decide if things still make sense!
I think the Insights overview page does a good job of explaining that it's about performance and tracing, but users might find it strange that generic-looking links like "our performance product" became "our insights product" (or similar, I'm just making up an example), since "Insights" is Sentry jargon
Work for getsentry/sentry#84021
We are removing the performance link from the sidebar, all performance pages will fall under insights.
This PR isn't to be merged for a few days until the performance link is removed, but we should have doc changes ready.
This PR updates the docs to reflect the layout of the product.
![image](https://private-user-images.githubusercontent.com/44422760/413083455-01f9d6e6-8d8c-4cb6-af0c-6a18f8dc9702.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTM3ODIsIm5iZiI6MTczOTU5MzQ4MiwicGF0aCI6Ii80NDQyMjc2MC80MTMwODM0NTUtMDFmOWQ2ZTYtOGQ4Yy00Y2I2LWFmMGMtNmExOGY4ZGM5NzAyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDA0MjQ0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5Nzg5ZWUwNTUwZDIyY2YxYTY4OTE3M2Q1NDVlNDZlNWM1NjAzMDMwMTIyMzE3Y2I1YjcwYWUyYjRjODU1MDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.9SJxiheEnB6bijMwmWgh1bBilVrX892Q5nn1jpCw5Xw)
/product/performance
is moved to/product/insights/overview
setup
,retention priorities
andperformance overhead
as these pages are more generic to insights