Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(insights): move performance docs under insights #12720

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Feb 13, 2025

Work for getsentry/sentry#84021

We are removing the performance link from the sidebar, all performance pages will fall under insights.

This PR isn't to be merged for a few days until the performance link is removed, but we should have doc changes ready.

This PR updates the docs to reflect the layout of the product.
image

  1. Most of /product/performance is moved to /product/insights/overview
  2. The exception to the above is the setup, retention priorities and performance overhead as these pages are more generic to insights
  3. Adds redirect for old perf pages -> insights
  4. Updates links for old perf pages to use insights links
  5. Some features are getting removed like web vitals in the transaction summary, information about those features have been removed

@DominikB2014 DominikB2014 requested a review from a team February 13, 2025 22:19
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 10:44pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 10:44pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 10:44pm

Copy link

codecov bot commented Feb 13, 2025

Bundle Report

Changes will increase total bundle size by 320 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.93MB -363 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 375.72kB 689 bytes (0.18%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json -118 bytes 375.94kB -0.03%
../app/platform-redirect/page.js.nft.json -118 bytes 375.85kB -0.03%
../app/sitemap.xml/route.js.nft.json -118 bytes 373.82kB -0.03%
view changes for bundle: sentry-docs-edge-server-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
src/middleware.js 689 bytes 205.04kB 0.34%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/ytVh_0hfMCjRyCwtwaGQ_/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/ytVh_0hfMCjRyCwtwaGQ_/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/9QyTe6WPcQyFyh3uy7TkZ/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/9QyTe6WPcQyFyh3uy7TkZ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 the changes look fine to me, but it should really be up to a PM to decide if things still make sense!

I think the Insights overview page does a good job of explaining that it's about performance and tracing, but users might find it strange that generic-looking links like "our performance product" became "our insights product" (or similar, I'm just making up an example), since "Insights" is Sentry jargon

@DominikB2014
Copy link
Contributor Author

DominikB2014 commented Feb 14, 2025

👀 the changes look fine to me, but it should really be up to a PM to decide if things still make sense!

@gggritso yup makes sense! These are changes that I spoke to @bcoe about already, he'll review these changes as well. We might tweak things to account for your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants