feat(nuxt): Use --import as the default installation method #12070
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 228 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
| }) | ||
| ``` | ||
|
|
||
| After setting this, the Sentry Nuxt SDK adds a Rollup plugin which wraps the server entry file with a dynamic `import()`. |
There was a problem hiding this comment.
l: This feels like a bit too much detail. Even the concept of server entry file is confusing, it sounds a bit like our server config file.
Maybe just saying that the build system will take care of ensuring import order using dynamic imports?
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/guides/nuxt/install/top-level-import.mdx
Outdated
Show resolved
Hide resolved
|
|
||
| We recommend using this only if the `--import` flag is not an option for you. |
There was a problem hiding this comment.
l: should we link to the --import guide? I know we reference it above but users might not have read it and jumped directly to the alert
| @@ -20,10 +20,12 @@ supported: | |||
| When running your application in ESM mode, you will most likely want to <PlatformLink to="/install/esm">follow the ESM instructions</PlatformLink>. However, if you want to avoid using the `--import` command line option, for example if you have no way of configuring a CLI flag, you can also follow an alternative setup that involves importing the `instrument.mjs` file directly in your application. | |||
There was a problem hiding this comment.
does this link exist? I think the link should point to the --import page, right?
There was a problem hiding this comment.
Those are the node docs, I just edited those as well as I copied the Alert content from there and I thought I add the suggestions I got in this PR in the Node docs as well.
Or should I rather open a new PR for this?
* feat(nuxt): Use --import as the default installation method * change to experimental_entrypointWrappedFunctions * review suggestions
Merge after release of
@sentry/nuxtv8.43.0DESCRIBE YOUR PR
Documenting based on this PR: getsentry/sentry-javascript#14553
Dynamic
import()is not the default anymore. Docs are changed accordinglyIS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: