Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable native orientation change on Android #2540

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Dec 25, 2024

📜 Description

This option was added in #2536

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (f735167) to head (a21f818).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
+ Coverage   88.49%   91.99%   +3.50%     
==========================================
  Files         120       89      -31     
  Lines        4407     3087    -1320     
==========================================
- Hits         3900     2840    -1060     
+ Misses        507      247     -260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1261.06 ms 1277.83 ms 16.77 ms
Size 8.42 MiB 9.86 MiB 1.44 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8d64376 1260.92 ms 1289.32 ms 28.40 ms
9928a74 1249.98 ms 1269.08 ms 19.10 ms
ddc97ad 1228.02 ms 1232.61 ms 4.59 ms
ef6466d 1209.88 ms 1225.81 ms 15.93 ms
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
7f97e6c 1250.63 ms 1274.47 ms 23.84 ms
1192c0a 1238.90 ms 1261.73 ms 22.83 ms
1cc9547 1230.81 ms 1260.79 ms 29.98 ms
6f3717a 1259.84 ms 1280.90 ms 21.06 ms
2b9937e 1226.27 ms 1265.18 ms 38.91 ms

App size

Revision Plain With Sentry Diff
8d64376 8.16 MiB 9.17 MiB 1.01 MiB
9928a74 8.16 MiB 9.17 MiB 1.01 MiB
ddc97ad 8.29 MiB 9.37 MiB 1.08 MiB
ef6466d 8.33 MiB 9.40 MiB 1.07 MiB
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
7f97e6c 8.38 MiB 9.78 MiB 1.40 MiB
1192c0a 8.42 MiB 9.86 MiB 1.44 MiB
1cc9547 8.42 MiB 9.86 MiB 1.44 MiB
6f3717a 8.33 MiB 9.62 MiB 1.29 MiB
2b9937e 8.38 MiB 9.78 MiB 1.40 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 479.26 ms 568.30 ms 89.04 ms
Size 6.46 MiB 7.48 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
43abc4f 406.54 ms 475.53 ms 68.99 ms
559d28f 302.35 ms 339.53 ms 37.18 ms
7f75f32 347.36 ms 419.58 ms 72.22 ms
e0f6628 380.21 ms 450.39 ms 70.17 ms
d5696bf 424.06 ms 425.58 ms 1.52 ms
0764150 469.49 ms 541.86 ms 72.37 ms
be8cafe 405.40 ms 470.95 ms 65.56 ms
d089990 361.67 ms 442.50 ms 80.83 ms
2261c15 370.00 ms 455.88 ms 85.88 ms
eecbbca 324.37 ms 352.49 ms 28.12 ms

App size

Revision Plain With Sentry Diff
43abc4f 6.35 MiB 7.34 MiB 1007.72 KiB
559d28f 5.94 MiB 6.92 MiB 1001.70 KiB
7f75f32 6.26 MiB 7.20 MiB 959.18 KiB
e0f6628 6.33 MiB 7.29 MiB 987.23 KiB
d5696bf 6.49 MiB 7.55 MiB 1.06 MiB
0764150 6.46 MiB 7.48 MiB 1.01 MiB
be8cafe 6.34 MiB 7.29 MiB 969.12 KiB
d089990 6.34 MiB 7.28 MiB 967.79 KiB
2261c15 6.27 MiB 7.20 MiB 957.75 KiB
eecbbca 5.94 MiB 6.89 MiB 975.78 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant