-
-
Notifications
You must be signed in to change notification settings - Fork 354
ci: refactor xcframework build workflows #5277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
armcknight
merged 17 commits into
armcknight/ci/parallelize-xcframework-build
from
armcknight/ci/refactor-xcframework-build-workflows
May 23, 2025
Merged
ci: refactor xcframework build workflows #5277
armcknight
merged 17 commits into
armcknight/ci/parallelize-xcframework-build
from
armcknight/ci/refactor-xcframework-build-workflows
May 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 776baf0.
Performance metrics 🚀
|
itaybre
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would try to remove Carthage
from the paths at some point, but that can be done later
fee2b24
into
armcknight/ci/parallelize-xcframework-build
70 checks passed
armcknight
added a commit
that referenced
this pull request
May 23, 2025
armcknight
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separately from #5218, and also for #4925, try to consolidate the new workflow implementation so it's not duplicated in the 3 places it's needed (build, release, benchmark)
One extra benefit here is that the UI test workflow that build the xcframework seems to have built two variants of it: Sentry-Dynamic and Sentry (the static lib). But, only the static lib was actually being used. So in addition to getting a faster build, we halved the amount of compute being used.
Another is that it's more obvious what each workflow is actually using, instead of having to dig through makefile, then build script logic, to see which xcframework variant is being build for "iOSOnly" or "gameOnly" parameters and which SDKs it's building for, including maccatalyst.
A third is that we don't need to build the mac catalyst version of the xcframework for the app size increase metric. The first comparison after merging to main will be smaller than the last one build with mac catalyst, but then going forward when like is compared to like, this check will be fine again, just run faster.
Improvements in CI times for the jobs using the reusable workflows:
Also, an improvement on #5218 is that the reusable workflow invocations with two stages of matrices are grouped by outer jobs instead of all being in one flat list, unordered (new vs old):
#skip-changelog