-
-
Notifications
You must be signed in to change notification settings - Fork 356
test: Refactor session tracker tests with application states #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5251 +/- ##
=============================================
+ Coverage 92.885% 92.900% +0.014%
=============================================
Files 688 688
Lines 86154 86272 +118
Branches 31175 31195 +20
=============================================
+ Hits 80025 80147 +122
+ Misses 6028 6024 -4
Partials 101 101
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this in an extra PR. LGTM.
Tests/SentryTests/Integrations/Session/SentrySessionTrackerTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, LGTM.
While working on #5121 I refactored the session tracker tests for readability and adding application state to mimic the states when using actual app to trigger
didBecomeActive
etc.It does not adapt the tests themselves.
#skip-changelog