Skip to content

meta: correct version setting #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 433 commits into
base: main
Choose a base branch
from

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Apr 25, 2025

I noticed something about how we version some things while going through the XcodeGen refactor: we were setting CURRENT_PROJECT_VERSION = 8.49.1 for the SentrySDK and SentrySwiftUI framework products. However, that setting is supposed to only be an integer value. The semantic version is supposed to go into MARKETING_VERSION.

We also had a couple disparate places where we would write the semver. So, this unifies them all into a single source of truth, and uses the correct build settings.

#skip-changelog; not specifically for #5165, but is currently interleaved with its changes

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.757%. Comparing base (6de664c) to head (eb8e248).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5139       +/-   ##
=============================================
- Coverage   92.762%   92.757%   -0.005%     
=============================================
  Files          677       677               
  Lines        84694     84699        +5     
  Branches     30794     30808       +14     
=============================================
+ Hits         78564     78565        +1     
- Misses        6030      6034        +4     
  Partials       100       100               
Files with missing lines Coverage Δ
...tegrations/SessionReplay/SentryReplayOptions.swift 96.202% <100.000%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de664c...eb8e248. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.61 ms 1247.80 ms 19.18 ms
Size 23.76 KiB 861.18 KiB 837.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4b22fc2 1192.15 ms 1217.31 ms 25.16 ms
0c3e79c 1227.77 ms 1257.90 ms 30.13 ms
9ef729b 1228.79 ms 1245.36 ms 16.57 ms
3297d6e 1209.27 ms 1231.19 ms 21.92 ms
48e8c2e 1226.45 ms 1246.85 ms 20.41 ms
ba5cc98 1228.06 ms 1248.15 ms 20.09 ms
b2f82fa 1237.78 ms 1256.02 ms 18.24 ms
189b629 1211.16 ms 1224.30 ms 13.14 ms
4597906 1228.37 ms 1242.29 ms 13.92 ms
8e4bc70 1229.18 ms 1240.86 ms 11.67 ms

App size

Revision Plain With Sentry Diff
4b22fc2 22.85 KiB 414.11 KiB 391.26 KiB
0c3e79c 22.30 KiB 829.54 KiB 807.24 KiB
9ef729b 20.76 KiB 432.88 KiB 412.12 KiB
3297d6e 21.58 KiB 418.44 KiB 396.86 KiB
48e8c2e 21.58 KiB 418.44 KiB 396.86 KiB
ba5cc98 22.30 KiB 832.29 KiB 809.99 KiB
b2f82fa 20.76 KiB 419.62 KiB 398.86 KiB
189b629 20.76 KiB 399.69 KiB 378.93 KiB
4597906 21.58 KiB 678.19 KiB 656.61 KiB
8e4bc70 21.58 KiB 625.90 KiB 604.32 KiB

Previous results on branch: armcknight/meta/correct-version-setting

Startup times

Revision Plain With Sentry Diff
19f26cd 1225.63 ms 1249.29 ms 23.66 ms
92918ce 1234.24 ms 1251.21 ms 16.96 ms

App size

Revision Plain With Sentry Diff
19f26cd 22.31 KiB 852.05 KiB 829.75 KiB
92918ce 22.31 KiB 852.06 KiB 829.75 KiB

armcknight added 30 commits May 7, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants