-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Change macro TEST and TESTCI to SENTRY_TEST and SENTRY_TEST_CI #4712
Conversation
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cce35c6 | 1228.88 ms | 1241.14 ms | 12.26 ms |
522f8da | 1230.19 ms | 1252.31 ms | 22.12 ms |
2154ae1 | 1216.06 ms | 1244.78 ms | 28.72 ms |
132ea11 | 1224.45 ms | 1254.47 ms | 30.02 ms |
3f366ee | 1244.49 ms | 1257.28 ms | 12.79 ms |
44ce888 | 1208.98 ms | 1224.72 ms | 15.74 ms |
3db3e35 | 1233.52 ms | 1256.43 ms | 22.90 ms |
973d574 | 1237.35 ms | 1256.15 ms | 18.80 ms |
b15521e | 1231.82 ms | 1252.23 ms | 20.41 ms |
4b22fc2 | 1192.15 ms | 1217.31 ms | 25.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cce35c6 | 20.76 KiB | 425.80 KiB | 405.04 KiB |
522f8da | 21.90 KiB | 726.18 KiB | 704.28 KiB |
2154ae1 | 20.76 KiB | 427.83 KiB | 407.06 KiB |
132ea11 | 21.90 KiB | 708.95 KiB | 687.05 KiB |
3f366ee | 20.76 KiB | 427.84 KiB | 407.08 KiB |
44ce888 | 22.85 KiB | 414.65 KiB | 391.80 KiB |
3db3e35 | 21.58 KiB | 419.21 KiB | 397.63 KiB |
973d574 | 21.58 KiB | 542.39 KiB | 520.81 KiB |
b15521e | 21.58 KiB | 573.18 KiB | 551.59 KiB |
4b22fc2 | 22.85 KiB | 414.11 KiB | 391.26 KiB |
Previous results on branch: philprime/issue-4638-test-macro-replacement
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8bc7f4f | 1226.51 ms | 1249.13 ms | 22.61 ms |
33ed280 | 1221.23 ms | 1243.82 ms | 22.58 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8bc7f4f | 22.31 KiB | 768.53 KiB | 746.21 KiB |
33ed280 | 22.31 KiB | 768.52 KiB | 746.21 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice thing to have, just need to fix CI.
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4712 +/- ##
=============================================
- Coverage 91.103% 91.102% -0.001%
=============================================
Files 624 624
Lines 72085 72090 +5
Branches 25595 25611 +16
=============================================
+ Hits 65672 65676 +4
Misses 6319 6319
- Partials 94 95 +1
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please merge this quickly to avoid merge conflicts.
Co-authored-by: Philipp Hofmann <[email protected]>
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
Replaced all occurences of the macros
TEST
andTESTCI
withSENTRY_TEST
andSENTRY_TEST_CI
💡 Motivation and Context
Closes #4638
💚 How did you test it?
CI checks
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps