Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logging for invalid cache directory path validation #4693

Merged
merged 14 commits into from
Jan 17, 2025

add additional error detection on older OS

a0ff34c
Select commit
Loading
Failed to load commit list.
Merged

fix: add logging for invalid cache directory path validation #4693

add additional error detection on older OS
a0ff34c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 17, 2025 in 1s

82.666% of diff hit (target 91.082%)

View this Pull Request on Codecov

82.666% of diff hit (target 91.082%)

Annotations

Check warning on line 33 in Sources/Sentry/SentryFileManager.m

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryFileManager.m#L33 

Added line #L33 was not covered by tests

Check warning on line 139 in Sources/Sentry/SentryFileManager.m

See this annotation in the file changed.

@codecov codecov / codecov/patch

Sources/Sentry/SentryFileManager.m#L139 

Added line #L139 was not covered by tests

Check warning on line 752 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L752 

Added line #L752 was not covered by tests

Check warning on line 771 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L771 

Added line #L771 was not covered by tests

Check warning on line 788 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L788 

Added line #L788 was not covered by tests

Check warning on line 804 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L804 

Added line #L804 was not covered by tests

Check warning on line 830 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L825-L830 

Added lines #L825 - L830 were not covered by tests

Check warning on line 832 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L832 

Added line #L832 was not covered by tests

Check warning on line 846 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L839-L846 

Added lines #L839 - L846 were not covered by tests

Check warning on line 848 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L848 

Added line #L848 was not covered by tests

Check warning on line 862 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L855-L862 

Added lines #L855 - L862 were not covered by tests

Check warning on line 864 in Tests/SentryTests/Helper/SentryFileManagerTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

Tests/SentryTests/Helper/SentryFileManagerTests.swift#L864 

Added line #L864 was not covered by tests
View more details on Codecov