-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(iOS-Swift): extract sdk config out of app delegate #4677
ref(iOS-Swift): extract sdk config out of app delegate #4677
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4623828 | 1242.06 ms | 1257.94 ms | 15.88 ms |
09b27a1 | 1235.10 ms | 1260.96 ms | 25.86 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4623828 | 22.31 KiB | 767.29 KiB | 744.98 KiB |
09b27a1 | 22.31 KiB | 767.23 KiB | 744.92 KiB |
Previous results on branch: armcknight/ref/app-delegate-sdk-config
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
226ebb9 | 1229.47 ms | 1252.14 ms | 22.67 ms |
00075a1 | 1233.84 ms | 1251.67 ms | 17.84 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
226ebb9 | 22.31 KiB | 767.29 KiB | 744.97 KiB |
00075a1 | 22.31 KiB | 767.29 KiB | 744.98 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please merge quickly to avoid merge conflicts.
For some reason iOS13-Swift can't be built because it can't see the declaration of |
Ugh, didn't realize that i set this to merge to my branch and not main 🤦🏻 |
@philipphofmann try again at #4684 |
This was violating the file length lint rule, so I just moved it out. Would make it easier to share between other sample apps later, as a bonus.
#skip-changelog