Skip to content
This repository was archived by the owner on Aug 30, 2023. It is now read-only.

Update instruction in the README #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tino
Copy link

@tino tino commented Apr 23, 2017

I was thrown off by instructions from an earlier version that talked about /account/settings/social/associate/complete/github/, and the current wording didn't make clear to me that this has changed. Hopefully this does to others :)

Also add a line about GITHUB_ORGANIZATION

@codecov-io
Copy link

codecov-io commented Apr 23, 2017

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #17   +/-   ##
====================================
  Coverage      49%   49%           
====================================
  Files           9     9           
  Lines         200   200           
====================================
  Hits           98    98           
  Misses        102   102

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397a658...7d62aec. Read the comment docs.

@dcramer
Copy link
Member

dcramer commented Apr 23, 2017

I'm not sure how this is really any different. Appears to me its just adding "for example", and makes the formatting less structured around it.

@tino
Copy link
Author

tino commented Apr 25, 2017

It changes the wording from "use the field as the sentry setting" to "use the sentry setting as the field value", which makes quite a lot of difference :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants