Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide monitoring-related configurations #3611

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Mar 10, 2025

In accordance with getsentry/sentry-docs#12660

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505 aldy505 requested a review from BYK March 10, 2025 04:29
Copy link
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is this rule in ansible, and I'm used to it, I don't know if applies to sentry as well, but it's good IMHO.

https://docs.ansible.com/ansible/latest/dev_guide/style_guide/grammar_punctuation.html#contractions

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thank you so much! 🚀

@BYK BYK merged commit 9486a83 into getsentry:master Mar 10, 2025
5 checks passed
@aldy505 aldy505 deleted the feat/monitoring branch March 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants