Use docker-compose if version is gte docker compose #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldy505
approved these changes
Mar 3, 2025
aminvakil
force-pushed
the
docker_compose_3587
branch
from
40f2502 to
f5a392c
Compare
BYK
requested changes
Mar 3, 2025
|
Great to see you again @aminvakil and thanks so much for the patch! 🚀 |
aminvakil
force-pushed
the
docker_compose_3587
branch
from
f5a392c to
6d85710
Compare
aminvakil
changed the title
|
I set STANDALONE_COMPOSE_VERSION to 2.40.0 to see if it really picks up and it failed with this line (as docker-compose does not exist): I think this PR is good to go. |
This reverts commit 75c021f.
aminvakil
changed the title
BYK
reviewed
Mar 3, 2025
BYK
approved these changes
Mar 3, 2025
aminvakil
commented
Mar 3, 2025
BYK
added a commit
that referenced
this pull request
Mar 5, 2025
With #3595, we now check both `docker-compose` and `docker compose` versions so this patch removes the implicit fallback to `docker-compose` for `$dc_base` and makes it explicit.
BYK
added a commit
that referenced
this pull request
Mar 5, 2025
With #3595, we now check both `docker-compose` and `docker compose` versions so this patch removes the implicit fallback to `docker-compose` for `$dc_base` and makes it explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3587
This PR tries to use docker-compose if its version is greater than docker compose.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.