ci: Move e2e test action into the repo #3519
Conversation
This is an initial transitionary patch before landing #3516. Once we land this, we will point https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml to this repo, land #3516, then update users of the old action to use this one and remove that repo.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3519 +/- ##
==========================================
- Coverage 97.58% 93.23% -4.35%
==========================================
Files 3 3
Lines 207 207
==========================================
- Hits 202 193 -9
- Misses 5 14 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Once we land this, we will point https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml to this repo, land #3516, then update users of the old action to use this one and remove that repo.
Is it needed to point https://github.com/getsentry/action-self-hosted-e2e-tests/blob/main/action.yml to this repo? Would it be better to put up PR's in snuba/relay directly to use the action.yaml workflow in the self-hosted repo to verify expected behavior before merging. Then, archive the action-self-hosted-e2e-tests repo once that looks stable
|
@hubertdeng123 yup you're right. I also realized this just before your comment and updated the PR description (and the commit log) |
This is an initial transitionary patch before landing #3516. Once we land this, we will update users of the old action to use this one and remove that repo. Then land #3516 safely.
Great thing is, with this patch and the subsequent update to getsentry/action-self-hosted-e2e-tests to use this one, all the repos would be using the Docker Volume caching we introduced in #3488.