Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vroom): Allow to customize vroom's environment variables in a different file #2866

Closed
wants to merge 3 commits into from
Closed

feat(vroom): Allow to customize vroom's environment variables in a different file #2866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85e9035
feat(vroom): Allow to customize vroom's environment variables in a di…
phacops Mar 7, 2024
04547b8
Move defaults to new environment file
phacops Mar 7, 2024
7143d88
Fix typo
phacops Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,8 @@ services:
vroom:
<<: *restart_policy
image: "$VROOM_IMAGE"
environment:
SENTRY_KAFKA_BROKERS_PROFILING: "kafka:9092"
SENTRY_KAFKA_BROKERS_OCCURRENCES: "kafka:9092"
SENTRY_BUCKET_PROFILES: file://localhost//var/lib/sentry-profiles
SENTRY_SNUBA_HOST: "http://snuba-api:1218"
env_file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require docker compose v2.24.0+. Which, I think we do want to get to due to how we can use this for docker compose env override files. For now though, for visibility purposes if we're going on this route it seems ok to include these vroom specific env variables into the .env file. I know it's not what you originally envisioned @aldy505, but will that do for now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't prefer this route, because that would mean there are no unified way to configure sentry services, as people know currently it's been done through config files and it works for most of the deployment models (docker compose, k8s, docker swarm, separate compose file, etc -- it's been told on the community) 😞. But since I'm not 100% of the community's voice here, I'd like to hear about what others (who self-hosted their sentry) )would say about this.

- ./vroom.env
volumes:
- sentry-vroom:/var/lib/sentry-profiles
depends_on:
Expand Down
4 changes: 4 additions & 0 deletions vroom.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
SENTRY_KAFKA_BROKERS_PROFILING="kafka:9092"
SENTRY_KAFKA_BROKERS_OCCURRENCES="kafka:9092"
SENTRY_BUCKET_PROFILES=file://localhost//var/lib/sentry-profiles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !
Looking forward to store profiles on something else than my drive.
it runs out of inodes too quickly.

SENTRY_SNUBA_HOST="http://snuba-api:1218"
Loading