Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance):Store perf score cdf measurement on span #4438

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Jan 9, 2025

Updates performance score calculation on spans and events to also store cdf values as measurements. We currently store two measurements per vital (weighted score and weight). Storing the cdf value instead will allow us to consolidate to a single measurement, since we really only need to use the cdf value in the product.

@edwardgou-sentry edwardgou-sentry self-assigned this Jan 9, 2025
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review January 13, 2025 17:45
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner January 13, 2025 17:45
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an "internal" changelog entry. Will the score and ratio measurements be removed eventually?

@edwardgou-sentry
Copy link
Contributor Author

Please add an "internal" changelog entry. Will the score and ratio measurements be removed eventually?

Yes, ideally we will be able to remove the score and ratio measurements. We're currently looking into moving performance product areas to start using span data from the EAP dataset. This is also a good opportunity to move over to the new measurement from this PR. There may also be some dashboard queries we'll need to migrate as well. All of this investigation is on going.

@edwardgou-sentry edwardgou-sentry merged commit 2e5e531 into master Jan 14, 2025
25 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/store-score-cdf-on-span branch January 14, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants