Skip to content

Commit

Permalink
fix(pii): Scrub user fields in span.sentry_tags (#4364)
Browse files Browse the repository at this point in the history
User fields are transferred into `span.sentry_tags` before PII
scrubbing. Most user fields are marked as `pii = true`, that is, they
should be scrubbed by default.

This PR

1. converts `sentry_tags` into a special type `SentryTags`, such that we
   can mark specific tags as `pii = true`,
2. adds `sentry_tags.user_ip` to the builtin PII selector for IP
   scrubbing.
  • Loading branch information
jjbayer authored Dec 10, 2024
1 parent 828d271 commit aa9c9bd
Show file tree
Hide file tree
Showing 10 changed files with 1,053 additions and 600 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Accept incoming requests even if there was an error fetching their project config. ([#4140](https://github.com/getsentry/relay/pull/4140))
- Rate limit profiles when transaction was sampled. ([#4195](https://github.com/getsentry/relay/pull/4195))
- Fix scrubbing user paths in minidump debug module names. ([#4351](https://github.com/getsentry/relay/pull/4351))
- Scrub user fields in span.sentry_tags. ([#4364](https://github.com/getsentry/relay/pull/4364))

**Features**:

Expand Down
Loading

0 comments on commit aa9c9bd

Please sign in to comment.