Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): Replace bot account with GitHub App #972

Merged
merged 3 commits into from
Dec 11, 2024
Merged

feat(security): Replace bot account with GitHub App #972

merged 3 commits into from
Dec 11, 2024

Conversation

Jeffreyhung
Copy link
Member

@Jeffreyhung Jeffreyhung commented Sep 10, 2024 •
edited
Loading

  • Release bot GitHub App created and installed to all repo
  • GitHub App client ID and private key added as organization variable and secret
  • Replaced the branch protection rule with Rulesets, and added the GitHub app to bypass list

Screenshot 2024-09-10 at 3 40 16 PM

Once the PR is merged and confirmed things are working correctly, we will remove access for the getsentry-release bot account

More details: https://www.notion.so/sentry/Replacing-Bot-Accounts-with-GitHub-Apps-1c2fa919c2ab4134b18b8a10c7ff1042?pvs=4

@Jeffreyhung Jeffreyhung marked this pull request as draft September 16, 2024 20:09
@Jeffreyhung Jeffreyhung marked this pull request as ready for review December 11, 2024 00:04
asottile-sentry
asottile-sentry approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeffreyhung Jeffreyhung merged commit 8d99f60 into main Dec 11, 2024
14 checks passed
@Jeffreyhung Jeffreyhung deleted the replace-bot-account-with-github-app branch December 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeffreyhung @asottile-sentry