Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Minor linter issues #520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Minor linter issues #520

wants to merge 2 commits into from

Conversation

vaind
Copy link
Contributor

@vaind vaind commented Feb 28, 2024

  • add missing gem cleanup
  • autofixed settings.json

asottile-sentry
asottile-sentry reviewed Feb 28, 2024
View reviewed changes
Dockerfile
Comment on lines 67 to +72
&& gem install -g --no-document \
&& gem cleanup all \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just because I'm curious -- what does this do? reading the output it looks like it didn't really uninstall anything:

#16 109.4 Cleaning up installed gems...
#16 109.4 Clean up complete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess nothing in this case, it's just what linter said is missing there. To me it sounds like having apt-get clean or apt-get autoremove - you may not need it most of the time but if you do, it's there and no need to come back to the image and investigate whether you can decrease the size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what linter ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some extension in vscode uses these: https://github.com/projectatomic/dockerfile_lint

@vaind vaind requested a review from asottile-sentry March 4, 2024 19:40
@vaind vaind force-pushed the fix/linter-issues branch from 77bb232 to fce3902 Compare May 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile-sentry asottile-sentry Awaiting requested review from asottile-sentry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vaind @asottile-sentry