fix: Avoid polling the consumer if it says it's paused #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in StreamProcessor where self.__is_paused, but at the
same time we poll the consumer and get messages.
File "sentry/runner/commands/run.py", line 455, in basic_consumer
run_processor_with_signals(processor, consumer_name)
File "sentry/utils/kafka.py", line 46, in run_processor_with_signals
processor.run()
File "arroyo/processing/processor.py", line 323, in run
self._run_once()
File "arroyo/processing/processor.py", line 442, in _run_once
assert self.__consumer.poll(0.1) is None
Breadcrumbs indicate that rebalancing was happening at that time. Could
it be that we were paused, but the consumer got more partitions
assigned? It doesn't make sense since we don't have cooperative-sticky
rebalancing enabled, let's add more logs and prevent the crash.
MeredithAnya
approved these changes
Dec 17, 2024
|
related: #413 |
lynnagara
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in StreamProcessor where self.__is_paused, but at the
same time we poll the consumer and get messages.
Breadcrumbs indicate that rebalancing was happening at that time. Could
it be that we were paused, but the consumer got more partitions
assigned? It doesn't make sense since we don't have cooperative-sticky
rebalancing enabled, let's add more logs and prevent the crash.
related: #391