ref: A better commit log format pt2 #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really don't want to port this to Rust, let's simplify the commit log format Also avoid putting important information in headers. This was a hack to avoid changing the message format earlier, but it should be avoided. The timestamp is now in the payload of the message
untitaker
approved these changes
Sep 28, 2023
fpacifici
reviewed
Sep 28, 2023
| payload = json.dumps( | ||
| { | ||
| "offset": value.offset, | ||
| "orig_message_ts": datetime.timestamp(value.orig_message_ts), |
There was a problem hiding this comment.
Is this for the alerts e2e SLO ?
There was a problem hiding this comment.
Not really, this is the same information that was already there, just in a float format and in the body not the header now so we don't need to do the custom decoding dance
lynnagara
added a commit
to getsentry/snuba
that referenced
this pull request
Sep 29, 2023
Ports https://github.com/getsentry/arroyo/blob/f43a9d69ab0e504869f88fcc39ede98bc0cc6807/arroyo/backends/kafka/commit.py to Rust. Note this only encodes and decodes the new format (after getsentry/arroyo#290) not the old one. The codec is not used yet.
lynnagara
added a commit
to getsentry/snuba
that referenced
this pull request
Sep 29, 2023
Ports https://github.com/getsentry/arroyo/blob/f43a9d69ab0e504869f88fcc39ede98bc0cc6807/arroyo/backends/kafka/commit.py to Rust. Note this only encodes and decodes the new format (after getsentry/arroyo#290) not the old one. The codec is not used yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #289